[ovs-dev] [PATCH v3 2/3] ofproto: Add table config to struct ofproto

Simon Horman horms at verge.net.au
Wed Dec 18 03:35:22 UTC 2013


On Tue, Dec 17, 2013 at 05:13:38PM -0800, Ben Pfaff wrote:
> On Mon, Dec 16, 2013 at 05:53:22PM +0900, Simon Horman wrote:
> > Add table config to to struct ofproto and set it
> > when a table mod message is received.
> > 
> > This is in preparation for changing the behaviour of the switch
> > based on table config.
> > 
> > Cc: Andy Zhou <azhou at nicira.com>
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Thanks.
> 
> I dropped the comment change in ofproto-provider.h, because it was
> wrong ('config' isn't guarded by anything, it's atomic).

Thanks, I should have fixed that up when I switched over
to using an atomic.

> I dropped this build-assert because ANSI C says every enum fits in an int:
> > +BUILD_ASSERT_DECL(sizeof(unsigned int) >= sizeof(enum ofp_table_config));

Thanks, I did not know that.

> I'll apply this in a minute.



More information about the dev mailing list