[ovs-dev] [PATCH v4.3 3/5] ofp-util: Implement OFPMP_TABLE_FEATURES en/decode

Alexander Wu alexander.wu at huawei.com
Wed Dec 18 07:58:32 UTC 2013


On 18/12/2013 08:51, Ben Pfaff wrote:
> On Mon, Dec 09, 2013 at 06:41:11PM +0800, Alexander Wu wrote:
>> v4.3:
>>    Rollback table id 255 to 253 according to OpenFlow spec and current implement
>>    Update AT.
>>
>> v4.2:
>>    Fix last table features id to 255.
>>    Add more comments.
>>    Fix wrong print of last table feature.
>>
>> v4:
>>    1. Delete duplication code.
>>    2. Add new acts in *.def.
>>    3. Update abstract table-features to bitmap.
>>    4. Make decode_openflow13_props more general.
>>    5. Update tests. Correct the wriable oxms.
>>
>> v3:
>>    1. Update names of functions/macros to make them meaningful.
>>    2. Fix codingstyle.
>>    3. Remove useless logic/struct/function.
>>    4. Make printable messages more friendly.
>>    5. Add OVS_ACTIONS macro to display all action features.
>>    6. Modify type of element_size and print error if 0.
>>    7. Change print of next_tables msg, change enums to OFPUTIL_*.
>>    8. Make all prints human-readable.
>>    9. Update printable messages: instruction/action/oxm/next_table.
>>    10. Update action features, now the actions are correct.
>>
>> v2:
>>    Restructure implement of OFPMP_TABLE_FEATURES
>>    Change decode_*_raw to normalized pull functions
>>
>>    1. add defines and funcs to decode table features
>>    2. restructure OFPMP_TABLE_FEATURES decode function
>>       restructure the function, now them acts like others.
>>    3. Change big array to defines.
>>       Change big array to defines.(oxm, table_feature_prop)
>>       Fix some names, now they're more meaningful.
>>    4. use macros to restructure implement
>>    5. Restructure get_* to more effective ones. (table_features, oxm)
>>    6. remove useless array and prototype
>>    7. Fix CodingStyle accoring to Simon Horman's suggestions.
>>    8. Fix print of NEXT_TABLE_MISS.
>>
>> Simon Horman's suggestions:
>>    Fix function paras alignment.
>>    Fix hard coding to marco.
>>    Fix VLOG calls with rl.
>>    Fix CodingStyle:
>>      max chars per line - 79
>>    Delete useless blank line.
>>    Restructure implement by macro.
>>
>> v1:
>>    ofp-util: Implement the encode/decode Table Features functions
>>
>>    1. Implement the encode/decode table features msgs function, and
>>       NOTE that we implement the decode functions *_raw, maybe we
>>       should change it the ofpbuf_pull?
>>    2. Add function to print OFPMP_TABLE_FEATURES.
>>       But now the print is crude and dirty.
>>       Fix it to bitmap or more desc later.
>>    3. Implement the at for OFPMP_TABLE_FEATURES.
>>       (I've tested it via NOX-OF1.3 too.)
>>
>> Signed-off-by: Alexander Wu <alexander.wu at huawei.com>
>
> Thanks.
>
> Makefile rules report:
>
>      ../lib/ofp-util.c:4417:        VLOG_WARN( "Bad table features format at offset %zu.",
>      ../lib/ofp-util.c:4480:        VLOG_WARN_RL(&bad_ofmsg_rl, "Bad property format at offset %zu.",
>      ../lib/ofp-util.c:4569:            "in message length %zu.", features_len, msg.size);
>      See above for list of violations of the rule that
>      'z', 't', 'j', 'hh' printf() type modifiers are
>      forbidden.  See CodingStyle for replacements.
>
> Will you please fix those issues?
>
> Thanks,
>
> Ben.
>
> .
>

Sure.
Fix it soon.

Thanks,

Alexander.




More information about the dev mailing list