[ovs-dev] [PATCH] bridge: Fix the command matching.

Jarno Rajahalme jrajahalme at nicira.com
Fri Dec 20 00:50:40 UTC 2013


LGTM

Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

> On Dec 19, 2013, at 1:50 PM, Alex Wang <alexw at nicira.com> wrote:
> 
> This commit fixes a command matching error introduced by commit
> 7155fa52f (ofproto-dpif: Add 'force-miss-model' configuration).
> 
> Signed-off-by: Alex Wang <alexw at nicira.com>
> ---
> vswitchd/bridge.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 9282c59..929033b 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -884,9 +884,9 @@ bridge_configure_flow_miss_model(const char *opt)
>     enum ofproto_flow_miss_model model = OFPROTO_HANDLE_MISS_AUTO;
> 
>     if (opt) {
> -        if (strcmp(opt, "with-facets")) {
> +        if (!strcmp(opt, "with-facets")) {
>             model = OFPROTO_HANDLE_MISS_WITH_FACETS;
> -        } else if (strcmp(opt, "without-facets")) {
> +        } else if (!strcmp(opt, "without-facets")) {
>             model = OFPROTO_HANDLE_MISS_WITHOUT_FACETS;
>         }
>     }
> -- 
> 1.7.9.5
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list