[ovs-dev] [PATCH] datapath: Fix sparse warning on BUILD_BUG_ON_INVALID()

[Andy Zhou]

Thanks, pushed to the master.


On Fri, Dec 20, 2013 at 5:34 PM, Pravin Shelar <pshelar at nicira.com> wrote:

> After chatting with Andy offline, it looks good to me.
>
> Acked-by: Pravin B Shelar <pshelar at nicira.com>
>
> On Fri, Dec 20, 2013 at 5:19 PM, Pravin Shelar <pshelar at nicira.com> wrote:
> > On Fri, Dec 20, 2013 at 4:25 PM, Andy Zhou <azhou at nicira.com> wrote:
> >> Sparse gives the following warnings when compile against Linux kernel
> >> 3.5:
> >>
> >>  CHECK   /root/projs/ovs/openvswitch/datapath/linux/skbuff-openvswitch.c
> >>  include/linux/mm.h:405:9: error: undefined identifier
> >>  'BUILD_BUG_ON_INVALID'
> >>  include/linux/mm.h:405:9: error: not a function <noident>
> >>
> >> The same issues may exists on 3.6 as well.
> >>
> > Can you define BUILD_BUG_ON_INVALID() like upstream kernel?
> >
> >> Signed-off-by: Andy Zhou <azhou at nicira.com>
> >> ---
> >>  datapath/linux/compat/include/linux/bug.h |   13 +++++++++++++
> >>  1 file changed, 13 insertions(+)
> >>  create mode 100644 datapath/linux/compat/include/linux/bug.h
> >>
> >> diff --git a/datapath/linux/compat/include/linux/bug.h
> b/datapath/linux/compat/include/linux/bug.h
> >> new file mode 100644
> >> index 0000000..551f07f
> >> --- /dev/null
> >> +++ b/datapath/linux/compat/include/linux/bug.h
> >> @@ -0,0 +1,13 @@
> >> +#ifndef __LINUX_BUG_WRAPPER_H
> >> +#define __LINUX_BUG_WRAPPER_H 1
> >> +
> >> +#include_next <linux/bug.h>
> >> +
> >> +#ifdef __CHECKER__
> >> +#ifndef BUILD_BUG_ON_INVALID
> >> +#define  BUILD_BUG_ON_INVALID(e) (0)
> >> +#endif
> >> +
> >> +#endif /* __CHECKER__ */
> >> +
> >> +#endif
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> dev mailing list
> >> dev at openvswitch.org
> >> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20131220/8466920d/attachment-0004.html>