[ovs-dev] [PATCH v2 1/3] userspace: add support for pop_eth and push_eth actions

[Ben Pfaff]

On Mon, Dec 30, 2013 at 10:38:40AM -0800, Ben Pfaff wrote:
> On Tue, Dec 24, 2013 at 04:02:34PM +0200, Lorand Jakab wrote:
> > These actions will allow L2->L3 and L3->L2 switching, and are supposed
> > to be added to flows installed in the datapath transparently by
> > ovs-vswitchd.
> > 
> > Signed-off-by: Lorand Jakab <lojakab at cisco.com>
> 
> This needs Jesse's approval for the change to include/linux/openvswitch.h.
> 
> The code in parse_odp_action() should be adapted to use ovs_scan() in
> place of sscanf().
> 
> Typo in comment on pop_eth(): s/funciton/function/
> 
> Otherwise:
> Acked-by: Ben Pfaff <blp at nicira.com>

I noticed one more thing: since pop_eth() drops MPLS headers it should
also set l2_5 to NULL.