[ovs-dev] [PATCH] connmgr: Log when a packet-in is dropped due to queue overflow.

[Ben Pfaff]

Thanks, I'll apply this in a minute.

On Fri, Dec 20, 2013 at 04:36:49PM -0800, Alex Wang wrote:
> Looks good the me,
> 
> 
> On Thu, Dec 5, 2013 at 9:21 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Reported-by: Anton Matsiuk <anton.matsiuk at gmail.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  AUTHORS           |    1 +
> >  ofproto/connmgr.c |    9 +++++++--
> >  2 files changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/AUTHORS b/AUTHORS
> > index 1c2d9ea..cb72ac8 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -132,6 +132,7 @@ Amey Bhide              abhide at nicira.com
> >  Amre Shakimov           ashakimov at vmware.com
> >  Andr? Ru?               andre.russ at hybris.com
> >  Andreas Beckmann        debian at abeckmann.de
> > +Anton Matsiuk           anton.matsiuk at gmail.com
> >  Atzm Watanabe           atzm at stratosphere.co.jp
> >  Bastian Blank           waldi at debian.org
> >  Ben Basler              bbasler at nicira.com
> > diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
> > index da25930..6b76e8a 100644
> > --- a/ofproto/connmgr.c
> > +++ b/ofproto/connmgr.c
> > @@ -1549,8 +1549,13 @@ do_send_packet_ins(struct ofconn *ofconn, struct
> > list *txq)
> >      LIST_FOR_EACH_SAFE (pin, next_pin, list_node, txq) {
> >          list_remove(&pin->list_node);
> >
> > -        rconn_send_with_limit(ofconn->rconn, pin,
> > -                              ofconn->packet_in_counter, 100);
> > +        if (rconn_send_with_limit(ofconn->rconn, pin,
> > +                                  ofconn->packet_in_counter, 100) ==
> > EAGAIN) {
> > +            static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 5);
> > +
> > +            VLOG_INFO_RL(&rl, "%s: dropping packet-in due to queue
> > overflow",
> > +                         rconn_get_name(ofconn->rconn));
> > +        }
> >      }
> >  }
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >