[ovs-dev] [dpif-netdev 04/15] dpif: Remove unused 'get_max_ports' from provider interface.

[Ethan Jackson]

Acked-by: Ethan Jackson <ethan at nicira.com>


On Fri, Dec 27, 2013 at 11:03 PM, Ben Pfaff <blp at nicira.com> wrote:
> Nothing ever called this function.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  lib/dpif-linux.c    |    7 -------
>  lib/dpif-netdev.c   |    7 -------
>  lib/dpif-provider.h |    4 ----
>  3 files changed, 18 deletions(-)
>
> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
> index 482ba77..7e97d87 100644
> --- a/lib/dpif-linux.c
> +++ b/lib/dpif-linux.c
> @@ -674,12 +674,6 @@ dpif_linux_port_query_by_name(const struct dpif *dpif, const char *devname,
>  }
>
>  static uint32_t
> -dpif_linux_get_max_ports(const struct dpif *dpif OVS_UNUSED)
> -{
> -    return MAX_PORTS;
> -}
> -
> -static uint32_t
>  dpif_linux_port_get_pid(const struct dpif *dpif_, odp_port_t port_no)
>  {
>      struct dpif_linux *dpif = dpif_linux_cast(dpif_);
> @@ -1615,7 +1609,6 @@ const struct dpif_class dpif_linux_class = {
>      dpif_linux_port_del,
>      dpif_linux_port_query_by_number,
>      dpif_linux_port_query_by_name,
> -    dpif_linux_get_max_ports,
>      dpif_linux_port_get_pid,
>      dpif_linux_port_dump_start,
>      dpif_linux_port_dump_next,
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 19fbdcf..bf23958 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -629,12 +629,6 @@ dpif_netdev_port_query_by_name(const struct dpif *dpif, const char *devname,
>      return error;
>  }
>
> -static uint32_t
> -dpif_netdev_get_max_ports(const struct dpif *dpif OVS_UNUSED)
> -{
> -    return MAX_PORTS;
> -}
> -
>  static void
>  dp_netdev_free_flow(struct dp_netdev *dp, struct dp_netdev_flow *netdev_flow)
>  {
> @@ -1455,7 +1449,6 @@ const struct dpif_class dpif_netdev_class = {
>      dpif_netdev_port_del,
>      dpif_netdev_port_query_by_number,
>      dpif_netdev_port_query_by_name,
> -    dpif_netdev_get_max_ports,
>      NULL,                       /* port_get_pid */
>      dpif_netdev_port_dump_start,
>      dpif_netdev_port_dump_next,
> diff --git a/lib/dpif-provider.h b/lib/dpif-provider.h
> index 90a02b4..6719b96 100644
> --- a/lib/dpif-provider.h
> +++ b/lib/dpif-provider.h
> @@ -144,10 +144,6 @@ struct dpif_class {
>      int (*port_query_by_name)(const struct dpif *dpif, const char *devname,
>                                struct dpif_port *port);
>
> -    /* Returns one greater than the largest port number accepted in flow
> -     * actions. */
> -    uint32_t (*get_max_ports)(const struct dpif *dpif);
> -
>      /* Returns the Netlink PID value to supply in OVS_ACTION_ATTR_USERSPACE
>       * actions as the OVS_USERSPACE_ATTR_PID attribute's value, for use in
>       * flows whose packets arrived on port 'port_no'.
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev