[ovs-dev] [PATCH 16/18] implement get_stats for NetBSD

YAMAMOTO Takashi yamamoto at valinux.co.jp
Fri Feb 1 02:38:50 UTC 2013


hi,

> On Thu, Jan 31, 2013 at 07:49:50PM +0900, YAMAMOTO Takashi wrote:
>> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
>> 
>> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> 
> Did you consider opening an AF_LINK socket only once instead of once per
> call?  The netdev_get_stats() function can sometimes be called often, so
> it may be best to avoid unneeded system calls.

ok.

> 
> Is there a reason not to squash this patch (and the previous one) into
> the earlier patch that modified netdev-bsd?  I do not see anything that
> keeps it conceptually distinct from that patch.

no reason.  it just reflected my development history.
do you prefer to fold them into one?

YAMAMOTO Takashi

> 
> Thanks,
> 
> Ben.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list