[ovs-dev] [PATCH] socket-util: Use set_nonblocking() helper function.

Ethan Jackson ethan at nicira.com
Fri Feb 1 22:52:05 UTC 2013


Acked-by: Ethan Jackson <ethan at nicira.com>

On Fri, Feb 1, 2013 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> There's no reason to inline this when we have a helper for it.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
> This is a repost of a patch originally posted Oct. 31, 2012.
>
>  lib/socket-util.c |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/lib/socket-util.c b/lib/socket-util.c
> index 3e3c67f..9fea7bd 100644
> --- a/lib/socket-util.c
> +++ b/lib/socket-util.c
> @@ -409,13 +409,8 @@ make_unix_socket(int style, bool nonblock,
>       * it will only happen if style is SOCK_STREAM or SOCK_SEQPACKET, and only
>       * if a backlog of un-accepted connections has built up in the kernel.)  */
>      if (nonblock) {
> -        int flags = fcntl(fd, F_GETFL, 0);
> -        if (flags == -1) {
> -            error = errno;
> -            goto error;
> -        }
> -        if (fcntl(fd, F_SETFL, flags | O_NONBLOCK) == -1) {
> -            error = errno;
> +        error = set_nonblocking(fd);
> +        if (error) {
>              goto error;
>          }
>      }
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list