[ovs-dev] [PATCH 2/2] tunnel: Treat in_key=0 the same as a missing in_key.

Ethan Jackson ethan at nicira.com
Fri Feb 8 21:42:12 UTC 2013


Thanks for the reviews.  I've pushed this to master and 1.10

Ethan

On Fri, Feb 8, 2013 at 8:45 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 07, 2013 at 07:04:22PM -0800, Ethan Jackson wrote:
>> The documented behavior of ovs is that a missing key is the
>> same as a zero key.  However, the tunneling code actually treated
>> them differently.  This could cause problems with tunneling modes
>> such as vxlan which always have a key.  Specifically, a tunnel with
>> no key configured, would send have to send traffic with a key of
>> zero.  However, the same tunnel would drop incoming traffic with a
>> zero key because it was expecting there to be none at all.
>>
>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>
> Looks good, thanks.



More information about the dev mailing list