[ovs-dev] [ext-272 0/4] Implement EXT-272 (role reply generation_ids)
Rajahalme, Jarno (NSN - FI/Espoo)
jarno.rajahalme at nsn.com
Tue Feb 12 15:31:16 UTC 2013
The patches look good, but as I haven't seen the EXT-272, I don't know if there is a possible conflict with the all-ones value returned when the generation id is undefined. Have you proposed to exclude the all-ones value from the set of valid generation ID values? Or does it matter?
Jarno
On Feb 12, 2013, at 10:03 , ext Ben Pfaff wrote:
> This implements the EXT-272 proposal for role reply generation_ids.
> It also slightly improves the role message handling code.
>
> Ben Pfaff (4):
> ofp-msgs: Fix typos in comment.
> ofp-msgs: New function ofpraw_decode_assert().
> ofp-util: Simplify struct ofputil_role_request.
> Make OpenFlow 1.2+ role replies return the generation ID.
>
> lib/ofp-msgs.c | 21 +++++++++-
> lib/ofp-msgs.h | 3 +-
> lib/ofp-print.c | 15 ++++---
> lib/ofp-util.c | 115 ++++++++++++++++++++++++++--------------------------
> lib/ofp-util.h | 7 ++--
> ofproto/connmgr.c | 40 +++++++++++-------
> ofproto/connmgr.h | 7 ++--
> ofproto/ofproto.c | 42 +++++++++----------
> ofproto/ofproto.h | 4 +-
> tests/ofp-print.at | 4 +-
> tests/ofproto.at | 4 +-
> vswitchd/bridge.c | 12 +++---
> 12 files changed, 150 insertions(+), 124 deletions(-)
>
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
More information about the dev
mailing list