[ovs-dev] [PATCH] ovs-ctl.in: Don't execute an empty restore_ofports script.

Gurucharan Shetty shettyg at nicira.com
Tue Feb 12 22:16:46 UTC 2013


On Tue, Feb 12, 2013 at 1:52 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Feb 12, 2013 at 09:40:17AM -0800, Gurucharan Shetty wrote:
>> While upgrading from openvswitch1.10, we need not
>> restore ofports across force-reload-kmod. This patch
>> fixes a bug wherein 'force-reload-kmod' command tried
>> to execute an empty script.
>>
>> Bug #15067
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> Why does executing an empty script cause a problem?
It does not have a '+x' set on that script as a file permission. So it
complains.
Probably the subject should have read, 'Don't execute the restore
ofport script in some cases.'

I could have tested on [ -x ${ script_ofports} ] before executing the
script instead
of nulling the variable. Either works fine.

Thanks,
Guru



More information about the dev mailing list