[ovs-dev] [PATCH 2/3] tests: Make long name more readable by introducing a shell variable.

Ben Pfaff blp at nicira.com
Wed Feb 13 19:22:05 UTC 2013


seq isn't in POSIX so I'm not sure we can rely on it.  For now, I left
it as-is.

Thanks for the review.

On Tue, Feb 12, 2013 at 05:59:42PM -0800, Ethan Jackson wrote:
> You may consider simply generating the name using seq i.e.
> 
> seq -s "" 200
> 
> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> On Fri, Feb 1, 2013 at 2:46 PM, Ben Pfaff <blp at nicira.com> wrote:
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  tests/library.at |    7 ++++---
> >  1 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/library.at b/tests/library.at
> > index d8280fd..3e84648 100644
> > --- a/tests/library.at
> > +++ b/tests/library.at
> > @@ -126,9 +126,10 @@ dnl for other platforms, so we skip the test there.
> >  AT_SETUP([test unix socket -- long pathname])
> >  AT_SKIP_IF([test ! -d /proc/self/fd])
> >  dnl Linux has a 108 byte limit; this is 150 bytes long.
> > -mkdir 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
> > -cd 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
> > -AT_CHECK([test-unix-socket ../012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789/socket socket])
> > +longname=012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
> > +mkdir $longname
> > +cd $longname
> > +AT_CHECK([test-unix-socket ../$longname/socket socket])
> >  AT_CLEANUP
> >
> >  AT_SETUP([ovs_assert])
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list