[ovs-dev] [ext-260 v2 4/6] ofp-errors: Implement OpenFlow 1.2+ experimenter error codes.

[Ben Pfaff]

On Wed, Feb 13, 2013 at 03:23:39PM -0800, Reid Price wrote:
> Python seems good, nice use of int(X, 0)

Thanks.

> One question on
> 
> > +                print "        {       -1, -1,  -1 }, /* %s */" % enum
> 
> If you moved the print outside this and used the same print (below) for both
> 
> > +                print "        { %#8x, %2d, %3d }, /* %s */" % (vendor, type_, code, enum)
> 
> this would've looked like -0x1.  If the else just did
> 
>   vendor = type_ = code = -1
> 
> in the else, seems easy to read/maintain

Yeah, I just don't like the look of -0x1, that's why I did it that
way.