[ovs-dev] [PATCH 3/6] vxlan: Add utility functions to the simap data structure.

Kyle Mestery (kmestery) kmestery at cisco.com
Thu Feb 14 17:41:16 UTC 2013


On Feb 14, 2013, at 11:37 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 14, 2013 at 09:37:27AM -0500, Kyle Mestery wrote:
>> Add utility functions to the simap structure. These are
>> used by future patches in this seris. The functions added are.
>> 
>> Signed-off-by: Kyle Mestery <kmestery at cisco.com>
>> Acked-by: Ethan Jackson <ethan at nicira.com>
> 
> Applied to master, thanks.
> 
> The standards fascist in me worried a bit about:
>> +    if (node) {
>> +        simap_delete(simap, node);
>> +    }
>> +    return node != NULL;
> because in C it is technically undefined behavior to do anything to a
> freed pointer, even compare it against NULL, so I changed it to avoid
> that.

That works for me, thanks Ben!



More information about the dev mailing list