[ovs-dev] [PATCH 3/4] tunnel: Generate datapath flows for tunneled packets dropped due to ECN.

Ben Pfaff blp at nicira.com
Thu Feb 14 20:12:37 UTC 2013


On Wed, Feb 13, 2013 at 03:31:44PM -0800, Justin Pettit wrote:
> Move the check for whether tunneled packets should be dropped due to
> congestion encountered (CE) when the encapsulated packet is not ECN
> capable (non-ECT).  This also adds some additional tests for ECN
> handling on tunnel decapsulation.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

I think we can put the test that this patch adds to do_xlate_actions()
in xlate_actions() instead, adding it as another clause (probably via
helper function?) in the same 'if' statement as the may_receive() test.
That's preferable because we'd only do it one time per translation
instead of once per resubmit.

The outer () is not needed here:
> +        && ((ctx->base_flow.tunnel.ip_tos & IP_ECN_MASK) == IP_ECN_CE)

Thanks,

Ben.



More information about the dev mailing list