[ovs-dev] [PATCH 3/6] ovs-bugtool: Ability to collect the number of rotated logs.

Gurucharan Shetty shettyg at nicira.com
Thu Feb 14 22:16:59 UTC 2013


On Thu, Feb 14, 2013 at 2:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 14, 2013 at 01:28:18PM -0800, Gurucharan Shetty wrote:
>> A big reason for a large debug bundle size is the size of log
>> files. By default we collect 20 rotated logs for each logfile.
>> Most of the times we collect the debug bundle as soon as we
>> hit a bug. In such cases, we know that we need only one day's
>> worth of logs.
>>
>> This patch adds an option, '--log-days' to ovs-bugtool wherein
>> we can specify how many days worth of rotated logs do we need
>> as part of the debug bundle.
>>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> I think that using range(n) tries to collect a log file with a .0
> extension.  I don't think logrotate generates those; I don't see any on
> my system here.  I guess that's harmless and an existing oddity, though.
Yes, I noticed it and is harmless. I wasn't sure if anything actually
generates .0, so left it as-is.


>
> Otherwise looks good, thanks.



More information about the dev mailing list