[ovs-dev] [PATCH 2/2] datapath: Fix parsing invalid LLC/SNAP ethertypes

Jesse Gross jesse at nicira.com
Fri Feb 15 21:31:20 UTC 2013


On Fri, Feb 8, 2013 at 3:29 PM, Rich Lane <rich.lane at bigswitch.com> wrote:
> Before this patch, if an LLC/SNAP packet with OUI 00:00:00 had an ethertype
> less than 1536 the flow key given to userspace in the upcall would contain the
> invalid ethertype (for example, 3). If userspace attempted to insert a kernel
> flow for this key it would be rejected by ovs_flow_from_nlattrs.
>
> This patch allows OVS to pass the OFTest pktact.DirectBadLlcPackets.
>
> Signed-off-by: Rich Lane <rlane at bigswitch.com>

This looks fine to me but I think that we also need to make the
equivalent change to userspace as well.



More information about the dev mailing list