[ovs-dev] [PATCH] vxlan: Create and delete tnl_backers in type_run()

Ben Pfaff blp at nicira.com
Fri Feb 15 21:51:59 UTC 2013

On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
> I think the main loop of this version still has some bugs.  It doesn't properly
> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
> changes (in some cases).  What about something like the following?  I think
> it's a little bit more straight forward.  I haven't tested it at all though.

The name tmp_simap is not good.  Perhaps tmp_backers or old_backers

I believe that your code is doing simap_delete() on 'node' then
dereferencing that same 'node' a few lines later.

I think that ofproto destruction will no longer delete tunnel ports.
I don't know whether that matters.



More information about the dev mailing list