[ovs-dev] [PATCH] vxlan: Create and delete tnl_backers in type_run()

Kyle Mestery (kmestery) kmestery at cisco.com
Fri Feb 15 22:01:27 UTC 2013


On Feb 15, 2013, at 3:56 PM, Kyle Mestery (kmestery) <kmestery at cisco.com> wrote:
> On Feb 15, 2013, at 3:51 PM, Ben Pfaff <blp at nicira.com> wrote:
>> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>>> I think the main loop of this version still has some bugs.  It doesn't properly
>>> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
>>> changes (in some cases).  What about something like the following?  I think
>>> it's a little bit more straight forward.  I haven't tested it at all though.
>> 
>> The name tmp_simap is not good.  Perhaps tmp_backers or old_backers
>> or…?
>> 
> I will change this in the patch.
> 
>> I believe that your code is doing simap_delete() on 'node' then
>> dereferencing that same 'node' a few lines later.
>> 
> I don't think so. If you look, the code which is assigning iter->odp_port first
> checks if node is NULL.
> 
>> I think that ofproto destruction will no longer delete tunnel ports.
>> I don't know whether that matters.
>> 
> I think the idea is for them to be deleted in type_run() instead.
> 
>> Thanks,
>> 
> One other thing I found with this code is that odp_port was not
> initialized to UINT32_MAX. I just fixed that and am testing it again.
> 
> Thanks,
> Kyle
> 
I just tested this out and it works now, thanks Ethan! I had to make one minor
change to your code. I resubmitted with your version of the main loop just now
as well.

Thanks!
Kyle




More information about the dev mailing list