[ovs-dev] [PATCH 03/11] datapath: Fold key_len and hash into sw_flow_key.

Jesse Gross jesse at nicira.com
Fri Feb 15 23:19:54 UTC 2013


On Mon, Feb 11, 2013 at 6:46 AM, Jarno Rajahalme
<jarno.rajahalme at nsn.com> wrote:
> Store key_len and hash fields at the end of struct sw_flow_key, past the
> area being hashed.
> Rename functions operating on keys from "_flow_" to "_flow_key_".
> Shift the responsibility for key hashing from lookup and insert to key
> construction side, which helps avaiding unnecessary hash computations.
>
> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>

This seems like three independent changes, so it really should be
broken up into different commits.  However, that being said, it also
needs more justification since I don't really see the benefit at the
moment.  In particular, how does moving the location of hash
computation reduce unnecessary work?



More information about the dev mailing list