[ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

[Jesse Gross]

On Mon, Feb 4, 2013 at 4:01 PM, Ben Pfaff <blp at nicira.com> wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 04a5e7f..2a542da 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -678,7 +678,6 @@ static int validate_userspace(const struct nlattr *attr)
>  {
>         static const struct nla_policy userspace_policy[OVS_USERSPACE_ATTR_MAX + 1] =   {
>                 [OVS_USERSPACE_ATTR_PID] = {.type = NLA_U32 },
> -               [OVS_USERSPACE_ATTR_USERDATA] = {.type = NLA_U64 },

It seems like it is better to keep this with type NLA_UNSPEC rather
than remove it completely.  There isn't any functional difference but
it seems to better reflect the intention.

Otherwise, this looks good to me.
Acked-by: Jesse Gross <jesse at nicira.com>