[ovs-dev] [PATCH] Tunnel: Cleanup old tunnel infrastructure.

Rajahalme, Jarno (NSN - FI/Espoo) jarno.rajahalme at nsn.com
Wed Feb 20 16:15:22 UTC 2013


On Feb 20, 2013, at 18:00 , ext Kyle Mestery (kmestery) wrote:

> On Feb 19, 2013, at 7:35 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> Since userspace flow based tunneling code is checked in, the kernel
>> port based tunneling code can be removed. Following patch removes
>> this tunnel compatibility code and simplifies it.
>> 
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>> 
>> Bug #15078
> 
> 
> I'm in the process of reviewing this now, and testing with patch 6/6 of the
> series I posted last week. Initial results show the destination port not being
> set for VXLAN ports. Looking into that now.
> 

I looked over this earlier today and it seems to me that also the vport_vxlan now ever keeps one vport around. For example, vxlan_tnl_destroy() does ovs_net->vport_net.vxlan_vport = NULL; which does not seem right, if there are multiple vxlan vports (one for each configured UDP destination port).

  Jarno




More information about the dev mailing list