[ovs-dev] [PATCH] in-band: Use "internal" netdev type for local ports.

Ben Pfaff blp at nicira.com
Fri Feb 22 14:53:06 UTC 2013


Looks good, thank you.
On Feb 21, 2013 9:18 PM, "Ethan Jackson" <ethan at nicira.com> wrote:

> A bridge's local port always has type "internal", so opening it
> with type "system" can't be correct.  This was causing problems
> with force-reload-kmod in some circumstances.
>
> Bug #15067.
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> ---
>  ofproto/in-band.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ofproto/in-band.c b/ofproto/in-band.c
> index 3b98005..1a08fcc 100644
> --- a/ofproto/in-band.c
> +++ b/ofproto/in-band.c
> @@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char
> *local_name,
>      int error;
>
>      *in_bandp = NULL;
> -    error = netdev_open(local_name, "system", &local_netdev);
> +    error = netdev_open(local_name, "internal", &local_netdev);
>      if (error) {
>          VLOG_ERR("failed to initialize in-band control: cannot open "
>                   "datapath local port %s (%s)", local_name,
> strerror(error));
> --
> 1.7.9.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130222/bcb9affa/attachment-0003.html>


More information about the dev mailing list