[ovs-dev] [PATCH] Add binary option for command outputs collected by ovs-bugtool

Ben Pfaff blp at nicira.com
Mon Feb 25 17:39:13 UTC 2013


On Fri, Feb 22, 2013 at 08:54:04AM -0800, Shih-Hao Li wrote:
> From: Shih-Hao Li <shihli at vmware.com>
> 
> Current ovs-bugtool collects command outputs as text strings.
> Thus it reads the output by lines. For commands that generate
> huge binary data, it becomes very inefficient to read the output.
> 
> The change here is to use a 1MB buffer to read binary data
> instead of reading them by lines.
> 
> Signed-off-by: Shih-Hao Li <shihli at vmware.com>

Is there a reason to distinguish between text and binary data?  That
is, could we just use a fixed-size buffer in every case?



More information about the dev mailing list