[ovs-dev] [PATCH] in-band: Use "internal" netdev type for local ports.

[Ethan Jackson]

So I looked over that commit and there does appear that there may be a
couple of additional incorrect invocations.  This is blocking quite a lot
of test work, and I don't have time to go through it at the moment so I'm
going to merge.  Ben, if you have time, since you wrote the original patch
would you mind having a look and making sure each netdev_open invocation is
correct?

Ethan


On Fri, Feb 22, 2013 at 11:03 AM, Justin Pettit <jpettit at nicira.com> wrote:

> It may be worth looking at commit 18812df (netdev: Get rid of struct
> netdev_options and netdev_open_default().) that introduced this issue,
> since there are a couple of other devices opened in a similar way.  In
> particular, I'm wondering about the fake bond device.
>
> Thanks for tracking down the original issue.
>
> --Justin
>
>
> On Feb 21, 2013, at 7:17 PM, Ethan Jackson <ethan at nicira.com> wrote:
>
> > A bridge's local port always has type "internal", so opening it
> > with type "system" can't be correct.  This was causing problems
> > with force-reload-kmod in some circumstances.
> >
> > Bug #15067.
> > Signed-off-by: Ethan Jackson <ethan at nicira.com>
> > ---
> > ofproto/in-band.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ofproto/in-band.c b/ofproto/in-band.c
> > index 3b98005..1a08fcc 100644
> > --- a/ofproto/in-band.c
> > +++ b/ofproto/in-band.c
> > @@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char
> *local_name,
> >     int error;
> >
> >     *in_bandp = NULL;
> > -    error = netdev_open(local_name, "system", &local_netdev);
> > +    error = netdev_open(local_name, "internal", &local_netdev);
> >     if (error) {
> >         VLOG_ERR("failed to initialize in-band control: cannot open "
> >                  "datapath local port %s (%s)", local_name,
> strerror(error));
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130225/d1ec1e9d/attachment-0004.html>