[ovs-dev] [PATCH] util: Increase k3wlness level.

Reid Price rprice at nicira.com
Tue Feb 26 03:33:10 UTC 2013


Looks good, one style nit.  I often see people bevel the first character, don't
know if that is canonical though.

On Mon, Feb 25, 2013 at 5:30 PM, Ethan Jackson <ethan at nicira.com> wrote:
> Acked-by: Ethan Jackson <ethan at nicira.com>
>
> This has the added benefit of making it really obvious when the switch
> restarted in the logs.  For that reason, I'd be in favor of backporting it
> to 1.10 to aid debugging until it gets more stable.  I don't feel that
> strongly about it though.
>
>
>
>
> On Mon, Feb 25, 2013 at 3:08 PM, Ben Pfaff <blp at nicira.com> wrote:
>>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>> ---
>>  lib/util.c |    9 ++++++++-
>>  1 files changed, 8 insertions(+), 1 deletions(-)
>>
>> diff --git a/lib/util.c b/lib/util.c
>> index cbaffa7..5a32c50 100644
>> --- a/lib/util.c
>> +++ b/lib/util.c
>> @@ -369,7 +369,14 @@ get_program_version(void)
>>  void
>>  ovs_print_version(uint8_t min_ofp, uint8_t max_ofp)
>>  {
>> -    printf("%s", program_version);
>> +    printf(""""""""""""""  ""          ""    """"""""""
>> +           ""          ""  ""          ""  ""          ""
>> +           ""          ""  ""          ""  ""
>> +           ""          ""  ""          ""    """"""""""
>> +           ""          ""    ""      ""                ""
>> +           ""          ""      ""  ""      ""          ""
>> +           """"""""""""""        ""          """"""""""
>> +           "%s", program_version);
>>      if (min_ofp || max_ofp) {
>>          printf("OpenFlow versions %#x:%#x\n", min_ofp, max_ofp);
>>      }
>> --
>> 1.7.2.5
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list