[ovs-dev] [PATCH 0/1] Unit tests for VXLAN and LISP

Kyle Mestery (kmestery) kmestery at cisco.com
Wed Feb 27 16:54:49 UTC 2013


On Feb 27, 2013, at 10:47 AM, Jesse Gross <jesse at nicira.com> wrote:
> On Wed, Feb 27, 2013 at 7:49 AM, Kyle Mestery <kmestery at cisco.com> wrote:
>> This adds unit tests for VXLAN and LISP. I'd like some feedback on this in the
>> following areas:
>> 
>> 1. Should I rename the existing tunnel.at to tunnel-gre.at and make the
>>   equivalent changes in the tests as well to reflect GRE?
>> 2. I added some tests around modifying the UDP port for VXLAN and LISP, but
>>   otherwise they are the same as the GRE tests.
> 
> There's a lot of duplicated code here that's effectively just testing
> the behavior of the common tunneling infrastructure.  Does it make
> more sense to have some basic tests to ensure that a given type of
> tunnel is recognized correctly plus tests for any special
> functionality (such as the UDP port number)?  It seems like that would
> give the vast majority of the benefit but would avoid the need to
> update multiple tests when behavior changes and also speed up running
> time.

OK, let me reverse course here by just adding some new tests to the existing
tunnel testing code to verify the tunnel types and also changing UDP destination
port numbers. I'll re-work this and send out a new patch later today.


More information about the dev mailing list