[ovs-dev] [PATCH v5] Tunnel: Cleanup old tunnel infrastructure.

Jesse Gross jesse at nicira.com
Wed Feb 27 23:53:41 UTC 2013


On Tue, Feb 26, 2013 at 10:01 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> Since userspace flow based tunneling code is checked in, the kernel
> port based tunneling code can be removed.
>
> Patch removes following components:
>  - tunnel ports hash table and moved tunnel ports list to individual
>    vports.
>  - Cleaned per tnl-port config.
>  - OVS_KEY_ATTR_TUN_ID action is removed.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> Bug #15078

Sorry to keep doing this but I realized that there is some more code
that we can delete:
 * We can dump all the protocol related header includes in tunnel.c.
Normally, I wouldn't really care but there's a lot of unrelated stuff
now.
 * Since this deletes any semblance of multicast support from the
kernel, we can do the equivalent from userspace as well.  This is
really just ofproto/tunnel.c:tnl_find() and blocking the addition of
multicast remote IPs in netdev-vport.c.
 * We can also remove the VXLAN bullet from the top of
ofproto/tunnel.c since that should work now and also multicast group
management since that's covered by the point above.
 * I noticed that there's also some remnant of patch ports in
include/linux/openvswitch.h that we can remove (this is probably a
separate patch).

This will be really great once all the old code is gone.



More information about the dev mailing list