[ovs-dev] [PATCH] ofproto-dpif: Ignore subfacet install errors.

Ben Pfaff blp at nicira.com
Thu Feb 28 00:36:07 UTC 2013


On Wed, Feb 27, 2013 at 03:49:00PM -0800, Ethan Jackson wrote:
> I intend to insert this before "ofproto-dpif: Handle tunnel config changes in
> facet_revalidate()."  Once this is reviewed, I'll push the whole series.
> 
> ---
> 
> When we fail to install a subfacet, there's not much we can do
> other than note that it happened.  However, doing this requires us
> to maintain a pointer to a subfacet which theoretically could be
> destroyed by facet_revalidate() later.  This patch solves the
> problem by simply assuming dpif_flow_put() always succeeds.  This
> should have no effect on behavior.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

This looks good.

I don't think the new ovs_assert() is necessary or helpful.  The
NOT_REACHED() was there before only because GCC complained if it
wasn't (it's a useful warning in some other places).

Thanks,

Ben.



More information about the dev mailing list