[ovs-dev] [PATCH] ofproto-dpif: Ignore subfacet install errors.

Ethan Jackson ethan at nicira.com
Thu Feb 28 00:47:04 UTC 2013


Sounds good, I'll remove the assert and merge the series.  Thanks for the
reviews.

Ethan


On Wed, Feb 27, 2013 at 4:36 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Feb 27, 2013 at 03:49:00PM -0800, Ethan Jackson wrote:
> > I intend to insert this before "ofproto-dpif: Handle tunnel config
> changes in
> > facet_revalidate()."  Once this is reviewed, I'll push the whole series.
> >
> > ---
> >
> > When we fail to install a subfacet, there's not much we can do
> > other than note that it happened.  However, doing this requires us
> > to maintain a pointer to a subfacet which theoretically could be
> > destroyed by facet_revalidate() later.  This patch solves the
> > problem by simply assuming dpif_flow_put() always succeeds.  This
> > should have no effect on behavior.
> >
> > Signed-off-by: Ethan Jackson <ethan at nicira.com>
>
> This looks good.
>
> I don't think the new ovs_assert() is necessary or helpful.  The
> NOT_REACHED() was there before only because GCC complained if it
> wasn't (it's a useful warning in some other places).
>
> Thanks,
>
> Ben.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130227/2860fa3e/attachment-0003.html>


More information about the dev mailing list