[ovs-dev] [PATCH v6] Tunnel: Cleanup old tunnel infrastructure.

Jesse Gross jesse at nicira.com
Thu Feb 28 21:08:01 UTC 2013


On Thu, Feb 28, 2013 at 11:32 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
> diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
> index 7d45930..1995f3a 100644
> --- a/ofproto/tunnel.c
> +++ b/ofproto/tunnel.c
> @@ -90,6 +88,9 @@ tnl_port_add__(const struct ofport *ofport, uint32_t odp_port,
>      cfg = netdev_get_tunnel_config(ofport->netdev);
>      ovs_assert(cfg);
>
> +    if (ip_is_multicast(cfg->ip_src))
> +        return NULL;

I think this check belongs in lib/netdev-vport.c:set_tunnel_config()
since that's where we do the other configuration sanity checking.
However, I think the multicast check should be on ip_dst since we
already have a check for multicast ip_src.



More information about the dev mailing list