[ovs-dev] [PATCH 2/2] datapath: Increase maximum allocation size of action list.

Pravin B Shelar pshelar at nicira.com
Thu Feb 28 19:02:09 UTC 2013


The switch to flow based tunneling increased the size of each output
action in the flow action list.  In extreme cases, this can result
in the action list exceeding the maximum buffer size.
This doubles the maximum buffer size to compensate for the increase
in action size.
Action list is recieved from netlink callback which is allocating
linear-skb, therefore allocating another multi-page buffer would
not increase probability of the allocation-failure by much.

Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
---
 datapath/flow.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/datapath/flow.h b/datapath/flow.h
index 6949640..887b6d4 100644
--- a/datapath/flow.h
+++ b/datapath/flow.h
@@ -194,7 +194,7 @@ int ovs_flow_from_nlattrs(struct sw_flow_key *swkey, int *key_lenp,
 int ovs_flow_metadata_from_nlattrs(struct sw_flow *flow, int key_len,
 				   const struct nlattr *attr);
 
-#define MAX_ACTIONS_BUFSIZE	(16 * 1024)
+#define MAX_ACTIONS_BUFSIZE	(32 * 1024)
 #define TBL_MIN_BUCKETS		1024
 
 struct flow_table {
-- 
1.7.1




More information about the dev mailing list