[ovs-dev] [PATCH 05/18] include strings.h for strcasecmp.

[Ben Pfaff]

On Fri, Feb 01, 2013 at 10:59:51AM +0900, YAMAMOTO Takashi wrote:
> hi,
> 
> > On Thu, Jan 31, 2013 at 07:49:39PM +0900, YAMAMOTO Takashi wrote:
> >> From: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
> >> 
> >> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> > 
> > I see many uses of strcasecmp() in the tree:
> > 
> >     blp at blp:~/nicira/ovs(0)$ git --no-pager grep -l strcasecmp
> >     lib/bundle.c
> >     lib/cfm.c
> >     lib/meta-flow.c
> >     lib/multipath.c
> >     lib/odp-util.c
> >     lib/ofp-parse.c
> >     lib/ofp-util.c
> >     lib/vlog.c
> >     utilities/ovs-ofctl.c
> >     utilities/ovs-vsctl.c
> >     vswitchd/bridge.c
> > 
> > but only one use of strings.h:
> > 
> >     lib/dpif-linux.c
> > 
> > I am surprised that your patch only adds one #include.  Why is that?
> 
> because only this one made gcc complain on my environment
> and i don't know ovs's header inclusion policy.
> for other places some other headers indirectly pulled it, i guess.

OK.

Thanks,

Ben.