[ovs-dev] [PATCH 1/1] lacp: Fix dumping of aggregation key

Ethan Jackson ethan at nicira.com
Wed Jan 2 23:25:49 UTC 2013


Thanks for the patch.  I made some minor tweaks to the commit message and
merged it.

Ethan

On Wed, Jan 2, 2013 at 9:23 AM, Anoob Soman <anoob.soman at citrix.com> wrote:

> While dumping lacp information using ovs-appctl, "aggregation key" field
> displays port_id even though aggregation-key is set using
> "other-config:lacp-aggregation-key".
>
> Signed-off-by: Anoob Soman <anoob.soman at citrix.com>
> ---
>  lib/lacp.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/lacp.c b/lib/lacp.c
> index 374d915..96857ea 100644
> --- a/lib/lacp.c
> +++ b/lib/lacp.c
> @@ -750,7 +750,9 @@ lacp_print_details(struct ds *ds, struct lacp *lacp)
>      ds_put_format(ds, "\tsys_priority: %u\n", lacp->sys_priority);
>      ds_put_cstr(ds, "\taggregation key: ");
>      if (lacp->key_slave) {
> -        ds_put_format(ds, "%u", lacp->key_slave->port_id);
> +        ds_put_format(ds, "%u", lacp->key_slave->key
> +                                ? lacp->key_slave->key
> +                                : lacp->key_slave->port_id);
>      } else {
>          ds_put_cstr(ds, "none");
>      }
> --
> 1.7.9.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130102/c94c214b/attachment-0003.html>


More information about the dev mailing list