[ovs-dev] [bug 14265 2/3] ovs-ofctl: Use vconn_open() instead of vconn_open_block() in open_vconn__().

[Ethan Jackson]

Acked-by: Ethan Jackson <ethan at nicira.com>


On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff <blp at nicira.com> wrote:

> All of the paths in open_vconn__(), except the one path that calls
> vconn_open() directly, just start the connection and do not block until
> it completes.  This changes the remaining path to work the same way.
>
> This will be important in an upcoming commit when in some cases we need to
> take an action between opening and connecting.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  utilities/ovs-ofctl.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index 239f317..bc2773e 100644
> --- a/utilities/ovs-ofctl.c
> +++ b/utilities/ovs-ofctl.c
> @@ -387,8 +387,7 @@ open_vconn__(const char *name, const char
> *default_suffix,
>      free(datapath_type);
>
>      if (strchr(name, ':')) {
> -        run(vconn_open_block(name, get_allowed_ofp_versions(),
> DSCP_DEFAULT,
> -                             vconnp),
> +        run(vconn_open(name, get_allowed_ofp_versions(), DSCP_DEFAULT,
> vconnp),
>              "connecting to %s", name);
>      } else if (!open_vconn_socket(name, vconnp)) {
>          /* Fall Through. */
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130104/fd5870b3/attachment-0003.html>