[ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

Ben Pfaff blp at nicira.com
Fri Jan 4 20:47:29 UTC 2013

On Fri, Jan 04, 2013 at 12:39:40PM -0800, Romain Lenglet wrote:
> On Jan 4, 2013, at 10:31 AM, Ben Pfaff <blp at nicira.com> wrote:
> >> +    return di;
> >> +}
> > 
> > In vswitch.ovsschema, I believe that we could limit obs_domain_id to the
> > 32-bit range, since it's a 32-bit value.  Is it worthwhile to do so?
> Good idea. I've done that, and done the changes you suggested for
> the other patches.


> Would you like me to send a squashed patch with all 4 patches?

Not yet.  I'll take a look at patch 4 so that I don't miss anything.
I'm also not sure whether I really want to insist on squashing these
together because it's more reviewable as-is.  It might be better if
they were split, as long as they were all pushed at the same time, and
the commit messages probably should mention that.

More information about the dev mailing list