[ovs-dev] [PATCH] include/linux/openvswitch.h: Make OVSP_LOCAL 32-bit.

Justin Pettit jpettit at nicira.com
Mon Jan 7 18:18:13 UTC 2013


On Jan 7, 2013, at 9:50 AM, Jesse Gross <jesse at nicira.com> wrote:

> On Mon, Jan 7, 2013 at 2:45 AM, Jarno Rajahalme <jarno.rajahalme at nsn.com> wrote:
>> 
>> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>
>> ---
>> ODP ports are now 32-bit, so OVSP_LOCAL should be too.
>> (Internally, kernel module still keeps port numbers 16-bit, though.)
> 
> Justin, I see two direct uses of OVSP_LOCAL in the ofproto directory.
> I didn't check them carefully but at first glance they doesn't seem
> right after the single datapath changes:
> in-band.c:                && nl_attr_get_u32(a) == OVSP_LOCAL) {
> ofproto-dpif.c:    if (!error && ofport->odp_port == OVSP_LOCAL) {

Great catch.  I'll prepare patches in a bit.  Thanks!

--Justin





More information about the dev mailing list