[ovs-dev] [PATCH 1/3] bond: Change rebalance ratio to be more fair

Ethan Jackson ethan at nicira.com
Mon Jan 7 22:12:06 UTC 2013

This seems fine to me.  My only comment is that we should probably add a
bit more explanation.  It took me 20 minutes just to figure out what this
code is intended to do.

 > +            /* Ideal ratio is 1, move it if the new ratio is closer to
> it. */

Perhaps we could expand this comment a bit?  Something like . . .

/* We're aiming for an ideal ratio of 1, meaning both the 'from' and 'to'
slave have the same load.  Therefore, we only move an entry if it decreases
the load on from, and brings us closer to equal traffic load. */

Perhaps the commit message could be expanded in a similar manner as well?
 I don't feel as strongly about that though.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130107/3f778332/attachment-0003.html>

More information about the dev mailing list