[ovs-dev] [PATCH 1/2] Fix handling of OFPP_ANY in OpenFlow 1.1 and later.

Justin Pettit jpettit at nicira.com
Tue Jan 8 18:16:00 UTC 2013


On Jan 4, 2013, at 8:58 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Jan 03, 2013 at 01:47:32PM -0800, Gurucharan Shetty wrote:
>> On Thu, Jan 3, 2013 at 11:20 AM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>>> Ouch.  This is nasty.  OFPP_NONE is definitely not the same as a
>>> wildcard.
>>> 
>>> I guess we have a few choices:
>>> 
>>>        1. Drop the "ANY" feature for wildcards for in_port (or for
>>>           all fields).  It's not so useful after all.
>>> 
>>>           This breaks backward compatibility for anyone who used that
>>>           feature.
>>> 
>>>        2. Switch back to "NONE" for the string version.
>>> 
>>>           Anyone who uses "ANY" (which we wouldn't document any
>>>           longer but which is a reasonable thing to do) would be
>>>           surprised.
>>> 
>>>        3. Use another string, e.g. "OFPP_ANY".
>>> 
>>>           This is not really consistent with the other special ports,
>>>           although I guess we could switch all of them at once.
>>> 
>>> Opinions?
>>> 
>> I do not have any strong opinions. Option 1, seems simpler.
> 
> Justin, I'd like to get specifically your opinion on this, if you have
> one.


Yes, this is unfortunate.  I think the first option is the best, since this is the new OpenFlow standard way of calling that port, so it's likely to only lead to more confusion going forward.  I sort of doubt that that many people use the "ANY" syntax, since fields are implicitly wildcarded if not specified.  If we go this route, we should drop support for wildcarding with "ANY" on fields, since that will be *really* confusing.  I think it still makes sense to support "*", though, so users can still explicitly wildcard a field if they want.

--Justin





More information about the dev mailing list