[ovs-dev] [PATCH] datapath: Change the single ENOENT return value to ENODEV in lookup_vport() to reduce the number of valid "no such device" error values that need special attention by the caller.

Jesse Gross jesse at nicira.com
Tue Jan 8 19:07:13 UTC 2013


On Tue, Jan 8, 2013 at 3:41 AM, Jarno Rajahalme <jarno.rajahalme at nsn.com> wrote:
> Userspace code will need to keep on checking for both ENODEV and ENOENT as
> long as older kernel modules are around.
>
> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>

OVS userspace actually uses this distinction to determine whether it
is the datapath or the port that doesn't exist.  For example, see
netdev_vport_set_config().  In general, it's also usually helpful to
have more information about the cause of the error as long as it
doesn't expose implementation details.

Also, would you mind keeping the subject of your patches to around 70
characters in the future so they don't wrap?



More information about the dev mailing list