[ovs-dev] [PATCH] ofproto-dpif: More efficient implementation of get_odp_port().

Ben Pfaff blp at nicira.com
Wed Jan 9 20:28:39 UTC 2013


On Wed, Jan 09, 2013 at 10:25:14PM +0200, Jarno Rajahalme wrote:
> On Jan 9, 2013, at 20:30 , ext Ben Pfaff wrote:
> 
> > On Wed, Jan 09, 2013 at 02:21:47PM +0200, Jarno Rajahalme wrote:
> >> Avoids unnecessary hash bucket traversal (ofproto_get_port()), since we
> >> have the ofport_dpif already after odp_port_to_ofport().
> >> 
> >> Signed-off-by: Jarno Rajahalme <jarno.rajahalme at nsn.com>
> > 
> > Thanks!
> > 
> > I was able to simplify the test to eliminate the ofproto_dpif_cast()
> > call.  I applied the following to master.
> 
> Thanks!
> 
> There is at least one similar use of ofproto_dpif_cast() that could
> be eliminated in the same way (odp_port_to_ofp_port()).

Yes, I had noticed the same thing:
        http://openvswitch.org/pipermail/dev/2013-January/024361.html



More information about the dev mailing list