[ovs-dev] [RFC flow tunnels 2/8] dpif-netdev: Allow stub interfaces on the dummy datapath.

Ben Pfaff blp at nicira.com
Fri Jan 11 17:06:30 UTC 2013


On Wed, Jan 09, 2013 at 03:43:42PM -0800, Ethan Jackson wrote:
> Future patches will need to add netdevs to the dummy datapath which
> can't actually send or receive packets.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Looks good.

This:
    if (error
        && (!dpif_netdev_class_is_dummy(dp->class) || error != EOPNOTSUPP)) {
might be more readable as:
    if (error
        && !(error == EOPNOTSUPP && dpif_netdev_class_is_dummy(dp->class))) {
but it's up to you.

Thanks,

Ben.



More information about the dev mailing list