[ovs-dev] [PATCH] remove restriction on socket name

Jesse Gross jesse at nicira.com
Tue Jan 15 02:14:47 UTC 2013


On Mon, Jan 14, 2013 at 4:57 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jan 14, 2013 at 03:37:43PM -0800, Pavithra Ramesh wrote:
>> Following patch removes restriction on the listening socket name that gets configured as bridge controller.
>> Currently, we only connect to sockets in a specific directory with the name of the bridge.
>> This patch removes the restriction on the bridge name (but keep the directory restriction).
>
> Please try to keep the lines of the commit message to about 75
> columns.  Above, the lines are as wide as 108 columns.
>
>> Issue: 14029
>
> We usually write these as "Bug #14029." or "Feature #14029." as
> appropriate in OVS commit messages.
>
>> Change-Id: I81a1d2b17bf4c66acc6933ec2fa48391e67e8126
>
> Open vSwitch doesn't use Gerrit, so the commit messages should not
> include a Change-Id.

On the other hand, it does need a signed-off-by line.

> The patch got corrupted.  All leading white space was missing.  See
> below:

I would use git send-email, it looks like the patch was converted to
HTML as part of the mangling.



More information about the dev mailing list