[ovs-dev] [PATCH 2/2] ovs-ctl.in: Restore flows across force-reload-kmod.

Ben Pfaff blp at nicira.com
Tue Jan 15 19:46:14 UTC 2013


On Fri, Jan 11, 2013 at 03:48:41PM -0800, Gurucharan Shetty wrote:
> If we want to upgrade from branch1.9 to master (or potential 1.10)
> and restore flows across force-reload-kmod, we need to maintain
> the value of ofport.
> 
> To do this, we fetch the value of ofport before the upgrade and use
> it to populate the column 'ofport_request' after ovsdb is upgraded.
> We need to do this before vswitchd is restarted as vswitchd
> needs the ofport_request column populated before it starts.
> 
> Issue #13556
> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

We seem to do this on every upgrade, but in fact it's only useful for
upgrades from 1.9 to 1.10 or later, right?  It would be better to do
this only when it is useful or at least note in the script why we are
doing it so we can remember to remove it later on.

Otherwise it seems reasonable.  Thank you!



More information about the dev mailing list