[ovs-dev] [PATCH 1/3] tests: Make test for Linux /proc/self/fd more straightforward.

Ben Pfaff blp at nicira.com
Wed Jan 16 17:28:12 UTC 2013


Presumably we can test for this Linux feature just by seeing whether the
directory is there.

Another goal is to shorten the code because I intend to make another copy
of it in an upcoming commit, to add a similar test for Python.

Signed-off-by: Ben Pfaff <blp at nicira.com>
---
 tests/library.at |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/tests/library.at b/tests/library.at
index 0765c3f..3334d23 100644
--- a/tests/library.at
+++ b/tests/library.at
@@ -124,17 +124,7 @@ dnl is about 100 bytes.  On Linux, we work around this by indirecting through
 dnl a directory fd using /proc/self/fd/<dirfd>.  We do not have a workaround
 dnl for other platforms, so we skip the test there.
 AT_SETUP([test unix socket -- long pathname])
-AT_CHECK([dnl
-    case `uname` in dnl (
-      *[[lL]]inux*)
-        exit 0
-        ;; dnl (
-      *)
-        dnl Magic exit code to tell Autotest to skip this test.
-        exit 77
-        ;;
-    esac
-])
+AT_SKIP_IF([test ! -d /proc/self/fd])
 dnl Linux has a 108 byte limit; this is 150 bytes long.
 mkdir 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
 cd 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
-- 
1.7.10.4




More information about the dev mailing list