[ovs-dev] [PATCH] dpif-linux: Fix segfault when a port already exists.

Ben Pfaff blp at nicira.com
Thu Jan 17 00:21:18 UTC 2013


On Wed, Jan 16, 2013 at 03:59:23PM -0800, Justin Pettit wrote:
> Commit 78a2d59c (dpif-linux.c: Let the kernel pick a port number if one
> not requested.) changed the logic for port assignment, but didn't
> properly handle some error conditions.  An attempt to add a tunnel port
> that already exists would lead to a segfault.  This commit fixes the
> logic to stop processing and return an error.
> 
> Reported-by: Gurucharan Shetty <shettyg at nicira.com>
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

This time for sure!

Looks good, thanks.



More information about the dev mailing list