[ovs-dev] [PATCH 01/16] User-Space MPLS actions and matches
jesse at nicira.com
Thu Jan 17 03:04:19 UTC 2013
On Wed, Jan 16, 2013 at 4:31 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Jan 17, 2013 at 09:27:03AM +0900, Simon Horman wrote:
>> > > I'm not sure why we have OVS_ACTION_ATTR_SET_MPLS instead of using
>> > > OVS_ACTION_SET to set OVS_KEY_ATTR_MPLS.
>> > For the PUSH/POP actions I think we also have the same issue with
>> > inserting in the middle of the list and can use the same solution.
>> I'm unsure what "inserting in the middle of the list" refers to.
> I think Jesse just means that you shouldn't add a new enum value in
> a way that changes existing enum values. (Took me a minute too.)
More information about the dev