[ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

[Ben Pfaff]

On Thu, Jan 17, 2013 at 01:27:21PM -0800, Ben Pfaff wrote:
> On Fri, Jan 11, 2013 at 09:55:41AM -0800, Romain Lenglet wrote:
> > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding
> > OFPACT_SAMPLE_IPFIX OVS action.
> > 
> > Signed-off-by: Romain Lenglet <rlenglet at vmware.com>
> 
> Here, I think that a default sampling probability of 0 is likely to be
> surprising.  I'd suggest that either we change it to something nonzero
> or make specifying the probability mandatory rather than having any
> default:
> > +.IP "\fBprobability=\fIpackets\fR"
> > +The number of sampled packets out of 65535.  Defaults to 0.  If 0,
> > +this action does nothing.
> 
> This should read 1.9.90:
> > +This action was added in Open vSwitch 1.9.1.

One more thing.  I think that you should consider mentioning IPFIX in
some of the bits of documentation where NetFlow is currently
mentioned, e.g. a grep finds:

FAQ:   vSwitch supports standard management interfaces (e.g. sFlow, NetFlow,
NEWS:    - Add support for NetFlow active timeouts
README:    * NetFlow, sFlow(R), and mirroring for increased visibility
WHY-OVS:  configuration (e.g. NetFlow, sFlow), etc.
WHY-OVS:  includes simple accounting and visibility support such as NetFlow and
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPAN, CLI, LACP, 802.
debian/control: and protocols (e.g. NetFlow, sFlow, SPAN, RSPA