[ovs-dev] [PATCH] datapath: Avoid null deref when GSO is for verifying header integrity only.
jesse at nicira.com
Mon Jan 21 23:10:06 UTC 2013
On Mon, Jan 21, 2013 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jan 21, 2013 at 02:25:34PM -0800, Jesse Gross wrote:
>> On Mon, Jan 21, 2013 at 10:11 AM, Ben Pfaff <blp at nicira.com> wrote:
>> > skb_gso_segment() has the following comment:
>> > * It may return NULL if the skb requires no segmentation. This is
>> > * only possible when GSO is used for verifying header integrity.
>> > Somehow queue_gso_packets() has never hit this case before, but some
>> > failures have suddenly been reported. This commit should fix the problem.
>> > Bug #14772.
>> > Reported-by: Deepesh Govindan <dgovindan at vmware.com>.
>> > Signed-off-by: Ben Pfaff <blp at nicira.com>
>> Acked-by: Jesse Gross <jesse at nicira.com>
>> However, I think we also potentially have a similar problem in
> May I leave the honors on that one to you?
Sure, I'll take it.
More information about the dev